Deprecate Channel.select splat overloads
#12813
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought the compiler will emit call to the splat overloads. But the expanded calls use I would prefer to this splat overloads to remain. So the compiler could emit the later and we can add overloads for optimized version for single/double channel actions. Of course we can check on the indexable size on runtime, so it's not big deal if we deprecate them. |
bcardiff
approved these changes
Dec 8, 2022
sdogruyol
approved these changes
Dec 22, 2022
|
Draft for now because it's not clear whether we might want to keep using these overloads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The splat-receiving overloads of
Channel.selectandChannel.blocking_selectare internal methods (:nodoc:) but never used internally. They can be removed. This patch only adds a deprecation, but it would probably be fine to just drop them entirely.They used to be part of the public select API. After the introduction of the
selectkeyword in #3130 they remained visible, but became nodoc in #9564.